Messages in this thread | | | Subject | Re: Potential uninitialized variables in cfg80211 | From | Johannes Berg <> | Date | Wed, 09 Oct 2019 08:45:28 +0200 |
| |
On Tue, 2019-10-08 at 14:19 -0700, Yizhuo Zhai wrote: > Hi All: > net/wireless/chan.c: > Inside function cfg80211_chandef_compatible(), variable "c1_pri40", > " c2_pri40", "c1_pri80" and "c2_pri80" could be uninitialized if > chandef_primary_freqs() fails. However, they are used later in the if > statement to decide the control flow, which is potentially unsafe.
I guess theoretically this is right, but the function should only be called with valid chandefs, and if chandef_primary_freqs() hit the warning then the chandef certainly wasn't valid.
johannes
| |