Messages in this thread | | | Date | Wed, 9 Oct 2019 10:24:55 +0200 | From | Marco Felsch <> | Subject | Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs |
| |
Hi Anson,
On 19-10-08 00:48, Anson Huang wrote: > Hi, Marco > > > On 19-10-07 09:15, Anson Huang wrote: > > > The SCU firmware does NOT always have return value stored in message > > > header's function element even the API has response data, those > > > special APIs are defined as void function in SCU firmware, so they > > > should be treated as return success always. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > --- > > > Changes since V1: > > > - Use direct API check instead of calling another function to check. > > > - This patch is based on > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > > > > hwork.kernel.org%2Fpatch%2F11129553%2F&data=02%7C01%7Canson. > > huang% > > > > > 40nxp.com%7C2de0a6be69b74cc249ad08d74afc9730%7C686ea1d3bc2b4c6f > > a92cd99 > > > > > c5c301635%7C0%7C0%7C637060321046247040&sdata=RMFAdLKGKb6 > > mEdhycrzHX > > > R03E6Qr5pWyRc8Zk6ErlBc%3D&reserved=0 > > > > Thanks for this v2. It would be good to change the callers within this series. > > NOT quite understand your point, the callers does NOT need to be changed, those > 2 special APIs callers are already following the right way of calling the APIs.
Ah okay. I searched the 5.4-rc2 tag and found the soc_uid_show() as only user but this user sets the have_resp field to false. Is this intended?
Regards, Marco
> Anson
| |