lkml.org 
[lkml]   [2019]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 13/13] KVM/nVMX: Use page_address_valid in a few more locations
    On Wed, Jan 09, 2019 at 10:42:13AM +0100, KarimAllah Ahmed wrote:
    > Use page_address_valid in a few more locations that is already checking for
    > a page aligned address that does not cross the maximum physical address.

    Where is this page_address_valid declared? The latest linus's tree does
    not have it, nor does your patchset?
    >
    > Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de>
    > ---
    > arch/x86/kvm/vmx/nested.c | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
    > index ccb3b63..77aad46 100644
    > --- a/arch/x86/kvm/vmx/nested.c
    > +++ b/arch/x86/kvm/vmx/nested.c
    > @@ -4203,7 +4203,7 @@ static int handle_vmon(struct kvm_vcpu *vcpu)
    > * Note - IA32_VMX_BASIC[48] will never be 1 for the nested case;
    > * which replaces physical address width with 32
    > */
    > - if (!PAGE_ALIGNED(vmptr) || (vmptr >> cpuid_maxphyaddr(vcpu)))
    > + if (!page_address_valid(vcpu, vmptr))
    > return nested_vmx_failInvalid(vcpu);
    >
    > if (kvm_read_guest(vcpu->kvm, vmptr, &revision, sizeof(revision)) ||
    > @@ -4266,7 +4266,7 @@ static int handle_vmclear(struct kvm_vcpu *vcpu)
    > if (nested_vmx_get_vmptr(vcpu, &vmptr))
    > return 1;
    >
    > - if (!PAGE_ALIGNED(vmptr) || (vmptr >> cpuid_maxphyaddr(vcpu)))
    > + if (!page_address_valid(vcpu, vmptr))
    > return nested_vmx_failValid(vcpu,
    > VMXERR_VMCLEAR_INVALID_ADDRESS);
    >
    > @@ -4473,7 +4473,7 @@ static int handle_vmptrld(struct kvm_vcpu *vcpu)
    > if (nested_vmx_get_vmptr(vcpu, &vmptr))
    > return 1;
    >
    > - if (!PAGE_ALIGNED(vmptr) || (vmptr >> cpuid_maxphyaddr(vcpu)))
    > + if (!page_address_valid(vcpu, vmptr))
    > return nested_vmx_failValid(vcpu,
    > VMXERR_VMPTRLD_INVALID_ADDRESS);
    >
    > --
    > 2.7.4
    >

    \
     
     \ /
      Last update: 2019-01-23 19:18    [W:4.088 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site