Messages in this thread | | | Date | Tue, 22 Jan 2019 19:42:54 +0200 | From | Leon Romanovsky <> | Subject | Re: [PATCH 5/8] infiniband: mlx5: no need to check return value of debugfs_create functions |
| |
On Tue, Jan 22, 2019 at 04:17:57PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Leon Romanovsky <leon@kernel.org> > Cc: Doug Ledford <dledford@redhat.com> > Cc: Jason Gunthorpe <jgg@ziepe.ca> > Cc: linux-rdma@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/infiniband/hw/mlx5/cong.c | 15 +++----- > drivers/infiniband/hw/mlx5/main.c | 8 ++--- > drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 +---- > drivers/infiniband/hw/mlx5/mr.c | 51 +++++----------------------- > 4 files changed, 18 insertions(+), 64 deletions(-) >
Thanks, Acked-by: Leon Romanovsky <leonro@mellanox.com> [unhandled content-type:application/pgp-signature] | |