Messages in this thread | | | Date | Sat, 8 Sep 2018 12:20:33 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH v2 2/2] irq/matrix: Spread managed interrupts on allocation |
| |
On Sat, 8 Sep 2018, Dou Liyang wrote: > Spread managed interrupt on allocation as well. > > Fixes: a0c9259dc4e1("irq/matrix: Spread interrupts on allocation")
No. This is an enhancement and not a fix.
> - cpumask_and(vector_searchmask, vector_searchmask, affmsk); > - cpu = cpumask_first(vector_searchmask); > - if (cpu >= nr_cpu_ids) > - return -EINVAL;
Removing this check changes the return value for the empty search mask case from EINVAL to ENOSPC. Doesn't matter much I think, but it might be worth to mention in the changelog.
Thanks,
tglx
| |