lkml.org 
[lkml]   [2018]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 3/7] firmware: coreboot: Make bus registration symmetric
Date
Quoting Julius Werner (2018-08-09 11:10:42)
> > @@ -138,8 +136,10 @@ int coreboot_table_init(struct device *dev, void __iomem *ptr)
> > ptr_entry += entry.size;
> > }
> >
> > - if (ret)
> > + if (ret) {
> > + bus_unregister(&coreboot_bus_type);
> > iounmap(ptr);
> > + }
>
> nit: maybe cleaner to just do if (ret) coreboot_table_exit(); here?
> You're essentially writing the same code again.

Ok.

\
 
 \ /
  Last update: 2018-08-10 01:32    [W:0.059 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site