Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 9 Aug 2018 23:59:49 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver |
| |
Hi!
> > Following node would describe strings connected to the outputs > > HVLED1 and HVLED2 controlled by bank A. > > > > led@0 { > > reg = <0>; > > led-sources = <0>. <1>; > > label = "white:first_backlight_cluster"; > > linux,default-trigger = "backlight"; > > }; > > > > > > IOW I agree with Pavel, but I propose to use already documented common > > DT LED property. > > > > I agree to use the led-sources but I still believe this approach may be confusing to other sw devs > and will lead to configuration issues by users. > > This implementation requires the sw dev to know which strings are controlled by which bank. > And this method may produce a misconfiguration like something below where HVLED2 is declared in > both bank A and bank B > > led@0 { > reg = <0>; > led-sources = <0>. <1>; > label = "white:first_backlight_cluster"; > linux,default-trigger = "backlight"; > }; > > led@1 { > reg = <1>; > led-sources = <1>. <2>; > label = "white:keypad_cluster"; > linux,default-trigger = "backlight"; > }; > > The driver will need to be intelligent and declare a miss > configuration on the above.
Yes. But please do it that way, it is still better than being different from all the other drivers.
Thanks, Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |