Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 9 Aug 2018 11:30:59 +0800 | From | zhong jiang <> | Subject | Re: [PATCH] drivers/net/usb/r8152: remove the unneeded variable "ret" in rtl8152_system_suspend |
| |
On 2018/8/9 10:28, Gustavo A. R. Silva wrote: > Hi Zhong, > > On 8/8/18 8:39 PM, zhong jiang wrote: >> rtl8152_system_suspend defines the variable "ret", but it is not modified >> after initialization. So just remove it. >> > Thanks for working on this. > > I wonder if you are using any tool like Coccinelle to spot these sort > of issues. If so, it'd be nice to mention that in the changelog. Yes, I use the returnval.cocci to spot it. I will remember for next time.
Thanks, zhong jiang > The above is important for two reasons, one is to give credit to the people > behind such tools, and the second one is to add support for metrics collection. > > Thanks > -- > Gustavo > > >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >> --- >> drivers/net/usb/r8152.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c >> index 124211a..9774270 100644 >> --- a/drivers/net/usb/r8152.c >> +++ b/drivers/net/usb/r8152.c >> @@ -4415,7 +4415,6 @@ static int rtl8152_runtime_suspend(struct r8152 *tp) >> static int rtl8152_system_suspend(struct r8152 *tp) >> { >> struct net_device *netdev = tp->netdev; >> - int ret = 0; >> >> netif_device_detach(netdev); >> >> @@ -4430,7 +4429,7 @@ static int rtl8152_system_suspend(struct r8152 *tp) >> napi_enable(napi); >> } >> >> - return ret; >> + return 0; >> } >> >> static int rtl8152_suspend(struct usb_interface *intf, pm_message_t message) >> >
| ![\](/images/icornerr.gif) |