lkml.org 
[lkml]   [2018]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] Drivers: hv: vmbus: Use raw_smp_processor_id() in vmbus_connect()
Date
> From: KY Srinivasan
> Sent: Thursday, August 30, 2018 10:32
> > > */
> > > if (version >= VERSION_WIN8_1) {
> > > msg->target_vcpu =
> > > - hv_cpu_number_to_vp_number(smp_processor_id());
> > > - vmbus_connection.connect_cpu = smp_processor_id();
> >
> > > + hv_cpu_number_to_vp_number(get_cpu());
> > > + vmbus_connection.connect_cpu = msg->target_vcpu;
> > > + put_cpu();
> >
> > While the warning " BUG: using smp_processor_id() in preemptible" can also
> > be avoided, the line
> > + vmbus_connection.connect_cpu = msg->target_vcpu;
> > seems incorrect, as the "connect_cpu" should reflect Linux CPU numbering
> > rather than Hyper-V's vCPU numbering.
>
> Yes of course! Can you send me a patch with the fix.
>
> K. Y

Ok. Will do.

-- Dexuan

\
 
 \ /
  Last update: 2018-08-30 20:09    [W:1.010 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site