lkml.org 
[lkml]   [2018]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] udf: remove unused variables group_start and nr_groups
    Date
    From: Colin Ian King <colin.king@canonical.com>

    Variables group_start and nr_groups are being assigned but are never used
    hence they are redundant and can be removed.

    Cleans up clang warning:
    variable 'group_start' set but not used [-Wunused-but-set-variable]
    variable 'nr_groups' set but not used [-Wunused-but-set-variable]

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    fs/udf/balloc.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
    index fcda0fc97b90..501bc5ffb4ce 100644
    --- a/fs/udf/balloc.c
    +++ b/fs/udf/balloc.c
    @@ -175,8 +175,8 @@ static int udf_bitmap_prealloc_blocks(struct super_block *sb,
    {
    struct udf_sb_info *sbi = UDF_SB(sb);
    int alloc_count = 0;
    - int bit, block, block_group, group_start;
    - int nr_groups, bitmap_nr;
    + int bit, block, block_group;
    + int bitmap_nr;
    struct buffer_head *bh;
    __u32 part_len;

    @@ -189,10 +189,8 @@ static int udf_bitmap_prealloc_blocks(struct super_block *sb,
    block_count = part_len - first_block;

    do {
    - nr_groups = udf_compute_nr_groups(sb, partition);
    block = first_block + (sizeof(struct spaceBitmapDesc) << 3);
    block_group = block >> (sb->s_blocksize_bits + 3);
    - group_start = block_group ? 0 : sizeof(struct spaceBitmapDesc);

    bitmap_nr = load_block_bitmap(sb, bitmap, block_group);
    if (bitmap_nr < 0)
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-08-29 12:17    [W:6.890 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site