Messages in this thread | | | From | Vaibhav Jain <> | Subject | Re: [Skiboot] [PATCH] opal/hmi: Wakeup the cpu before reading core_fir | Date | Thu, 23 Aug 2018 17:02:51 +0530 |
| |
Thanks for reviewing this patch Nick
Nicholas Piggin <npiggin@gmail.com> writes: > > Would it be feasible to enumerate the ranges of scoms that require > special wakeup and check for those in xscom_read/write, and warn if > spwkup was not set? > I think that might be racy (Vaidy please correct if I am wrong) as a core can change its state when we read its sleep state and when we do the actual xscom to read the core_fir.
-- Vaibhav Jain <vaibhav@linux.vnet.ibm.com> Linux Technology Center, IBM India Pvt. Ltd.
| |