Messages in this thread | | | From | "Brown, Aaron F" <> | Subject | RE: [Intel-wired-lan] [PATCH] net: intel: igb: Replace mdelay() with msleep() in igb_integrated_phy_loopback() | Date | Thu, 23 Aug 2018 21:05:33 +0000 |
| |
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Jia-Ju Bai > Sent: Friday, July 27, 2018 1:08 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com> > Cc: netdev@vger.kernel.org; Jia-Ju Bai <baijiaju1990@gmail.com>; intel- > wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] net: intel: igb: Replace mdelay() with > msleep() in igb_integrated_phy_loopback() > > igb_integrated_phy_loopback() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> > --- > drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
| |