lkml.org 
[lkml]   [2018]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 29/29] cls_matchall: fix tcf_unbind_filter missing
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hangbin Liu <liuhangbin@gmail.com>

    [ Upstream commit a51c76b4dfb30496dc65396a957ef0f06af7fb22 ]

    Fix tcf_unbind_filter missing in cls_matchall as this will trigger
    WARN_ON() in cbq_destroy_class().

    Fixes: fd62d9f5c575f ("net/sched: matchall: Fix configuration race")
    Reported-by: Li Shuang <shuali@redhat.com>
    Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
    Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/sched/cls_matchall.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/net/sched/cls_matchall.c
    +++ b/net/sched/cls_matchall.c
    @@ -112,6 +112,8 @@ static void mall_destroy(struct tcf_prot
    if (!head)
    return;

    + tcf_unbind_filter(tp, &head->res);
    +
    if (tc_should_offload(dev, head->flags))
    mall_destroy_hw_filter(tp, head, (unsigned long) head);


    \
     
     \ /
      Last update: 2018-08-21 08:38    [W:4.198 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site