Messages in this thread | | | Date | Mon, 20 Aug 2018 22:02:01 +0530 | From | Nishad Kamdar <> | Subject | Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages |
| |
On Sun, Aug 19, 2018 at 01:34:01PM +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > > Fixed four debug macros and their usages. Replaced printk with > > dev_<level> without __func__ or __LINE__ or current->comm and > > current->pid. Further removed the do {} while(0) loop for single > > statement macros. > > Out of the four, replaced all usages of ERR_MSG and IRQ_MSG with > > dev_err() in the code itself and dropped them from dbg.h. > > Removed all INIT_MSG usages and dropped it from dgb.h. > > Issues found by checkpatch. > > This needs to be multiple patches. One for each type of macro you are > deleting/changing, not all lumped together into one big patch. > > Plaese fix that up and resend. > > thanks, > > greg k-h
Ok, I'll do that.
Thanks for the review.
regards, nishad
| |