lkml.org 
[lkml]   [2018]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/7] pinctrl: ingenic: Merge GPIO functionality
Hi, this email is from Rob's (experimental) review bot. I found a couple
of common problems with your patch. Please see below.

On Thu, 16 Aug 2018 18:35:40 +0200, Paul Cercueil wrote:
> Merge the code of the gpio-ingenic driver into the pinctrl-ingenic
> driver.
>
> The reason behind this, is that the same hardware block handles both pin
> config / muxing and GPIO.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>

The preferred subject prefix is "dt-bindings: <binding dir>: ...".

> ---
> .../bindings/pinctrl/ingenic,pinctrl.txt | 38 ++-
> drivers/pinctrl/Kconfig | 2 +
> drivers/pinctrl/pinctrl-ingenic.c | 337 ++++++++++++++++++++-
> 3 files changed, 365 insertions(+), 12 deletions(-)
>

DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.

\
 
 \ /
  Last update: 2018-08-17 17:10    [W:0.044 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site