lkml.org 
[lkml]   [2018]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Query on shrink list
On Fri, Aug 17, 2018 at 03:39:22PM +0530, Mukesh Ojha wrote:
> Hi Al Viro,
>
> Is there is reason we have kept data->found++, if the dentry already there
> in shrink list ?
>
> static enum d_walk_ret select_collect(
> ...
>         if (dentry->d_flags & DCACHE_SHRINK_LIST) {
>                 data->found++;
>         } else {
>   ..
>
> If the dentry is already there on shrink list, does it not mean that
> data->found is already non-zero ?

Nope. It can be on *another* shrink list - if two processes are doing
that...

> Can't we just go out from here directly?

\
 
 \ /
  Last update: 2018-08-17 14:58    [W:0.048 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site