lkml.org 
[lkml]   [2018]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] coresight: etb10: Refactor etb_drvdata::mode handling
    From
    Date
    On 16/08/18 16:48, Mathieu Poirier wrote:
    > On Thu, Aug 16, 2018 at 04:13:03PM +0100, Suzuki K Poulose wrote:
    >> Hi Mathieu,
    >>
    >> The patch looks good to me. One minor nit below.
    >
    > You have not included any comment - did you change your mind?
    >

    Sorry, yes I did. It was about folding the checks where ETB is already
    enabled in SYSFS.

    >>
    >> On 14/08/18 23:14, Mathieu Poirier wrote:
    >>> This patch moves the etb_drvdata::mode from a locat_t to a simple u32,
    >>> as it is for the ETF and ETR drivers. This streamlines the code and adds
    >>> commonality with the other drivers when dealing with similar operations.
    >>>
    >>> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    >>> ---
    >>> drivers/hwtracing/coresight/coresight-etb10.c | 62 +++++++++++++++------------
    >>> 1 file changed, 34 insertions(+), 28 deletions(-)
    >>>
    >>> diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
    >>> index 9fd77fdc1244..69287163ce4e 100644
    >>> --- a/drivers/hwtracing/coresight/coresight-etb10.c
    >>> +++ b/drivers/hwtracing/coresight/coresight-etb10.c
    >>
    >>> @@ -488,7 +494,7 @@ static void etb_dump(struct etb_drvdata *drvdata)
    >>> unsigned long flags;
    >>> spin_lock_irqsave(&drvdata->spinlock, flags);
    >>> - if (local_read(&drvdata->mode) == CS_MODE_SYSFS) {
    >>> + if (drvdata->mode == CS_MODE_SYSFS) {
    >>> etb_disable_hw(drvdata);
    >>> etb_dump_hw(drvdata);
    >>> etb_enable_hw(drvdata);
    >>
    >> Looks good to me.
    >>
    >> Reviewed-by : Suzuki K Poulose <suzuki.poulose@arm.com>

    Suzuki

    \
     
     \ /
      Last update: 2018-08-16 17:51    [W:2.689 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site