Messages in this thread | | | Date | Thu, 16 Aug 2018 21:44:59 +1000 | From | Stephen Rothwell <> | Subject | Re: [PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages |
| |
Hi David,
On Thu, 16 Aug 2018 12:06:24 +0200 David Hildenbrand <david@redhat.com> wrote: > > -static int __ref __offline_pages(unsigned long start_pfn, > - unsigned long end_pfn) > +/* Must be protected by mem_hotplug_begin() or a device_lock */ > +int offline_pages(unsigned long start_pfn, unsigned long nr_pages)
You lose the __ref marking. Does this introduce warnings since offline_pages() calls (at least) zone_pcp_update() which is marked __meminit.
-- Cheers, Stephen Rothwell [unhandled content-type:application/pgp-signature] | |