Messages in this thread Patch in this message | | | From | efremov@linux ... | Subject | [PATCH v2] coccicheck: return proper error code on fail | Date | Fri, 10 Aug 2018 23:25:55 +0300 |
| |
From: Denis Efremov <efremov@linux.com>
If coccicheck fails, it should return an error code distinct from zero to signal about an internal problem. Current code instead of exiting with the tool's error code returns the error code of 'echo "coccicheck failed"' which is almost always equals to zero, thus failing the original intention of alerting about a problem. This patch fixes the code.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov <efremov@linux.com> --- scripts/coccicheck | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck index 9fedca611b7f..e04d328210ac 100755 --- a/scripts/coccicheck +++ b/scripts/coccicheck @@ -128,9 +128,10 @@ run_cmd_parmap() { fi echo $@ >>$DEBUG_FILE $@ 2>>$DEBUG_FILE - if [[ $? -ne 0 ]]; then + err=$? + if [[ $err -ne 0 ]]; then echo "coccicheck failed" - exit $? + exit $err fi } -- 2.17.1
| |