Messages in this thread | | | Date | Fri, 10 Aug 2018 09:06:01 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable |
| |
On Fri, 10 Aug 2018 06:01:34 -0700 Joel Fernandes <joelaf@google.com> wrote:
> > Even though, it should be verified or atleast commented on the function header. > > Ok. ftrace/core has been fixed since since so this patch is outdated > and isn't needed any more, but I agree a separate patch doc comment > would help make it clear about this fact. Both IRQ and preempt > tracepoints work this way, they fire only within their critical > section.
Note, I'm keeping the patch in the git history. As an artifact that can be found easily when looking at this code for further enhancements.
Feel free to send a patch that adds comments to these callbacks.
-- Steve
| |