Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] ACPI: save NVS memory for ASUS 1025C laptop | Date | Mon, 09 Jul 2018 11:46:23 +0200 |
| |
On Sunday, July 8, 2018 4:20:17 PM CEST Willy Tarreau wrote: > Every time I tried to upgrade my laptop from 3.10.x to 4.x I faced an > issue by which the fan would run at full speed upon resume. Bisecting > it showed me the issue was introduced in 3.17 by commit 821d6f0359b0 > (ACPI / sleep: Do not save NVS for new machines to accelerate S3). This > code only affects machines built starting as of 2012, but this Asus > 1025C laptop was made in 2012 and apparently needs the NVS data to be > saved, otherwise the CPU's thermal state is not properly reported on > resume and the fan runs at full speed upon resume. > > Here's a very simple way to check if such a machine is affected : > > # cat /sys/class/thermal/thermal_zone0/temp > 55000 > > ( now suspend, wait one second and resume ) > > # cat /sys/class/thermal/thermal_zone0/temp > 0 > > (and after ~15 seconds the fan starts to spin) > > Let's apply the same quirk as commit cbc00c13 (ACPI: save NVS memory > for Lenovo G50-45) and reuse the function it provides. Note that this > commit was already backported to 4.9.x but not 4.4.x. > > Cc: <stable@vger.kernel.org> # 3.17+: requires cbc00c13 > Signed-off-by: Willy Tarreau <w@1wt.eu>
Please resend this one with a CC to linux-acpi@vger.kernel.org
> --- > drivers/acpi/sleep.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c > index 974e584..af54d7b 100644 > --- a/drivers/acpi/sleep.c > +++ b/drivers/acpi/sleep.c > @@ -338,6 +338,14 @@ static const struct dmi_system_id acpisleep_dmi_table[] __initconst = { > DMI_MATCH(DMI_PRODUCT_NAME, "K54HR"), > }, > }, > + { > + .callback = init_nvs_save_s3, > + .ident = "Asus 1025C", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > + DMI_MATCH(DMI_PRODUCT_NAME, "1025C"), > + }, > + }, > /* > * https://bugzilla.kernel.org/show_bug.cgi?id=189431 > * Lenovo G50-45 is a platform later than 2012, but needs nvs memory >
| |