lkml.org 
[lkml]   [2018]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] locking/lockdep: Report comm/pid/timestamp information
On Mon, Jul 09, 2018 at 02:57:25AM +0200, Eugeniu Rosca wrote:
> diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
> index 6fc77d4dbdcd..eeed7ea2e198 100644
> --- a/include/linux/lockdep.h
> +++ b/include/linux/lockdep.h
> @@ -186,6 +186,10 @@ struct lock_list {
> struct list_head entry;
> struct lock_class *class;
> struct stack_trace trace;
> + unsigned long long ts;
> + char comm[16];
> + pid_t pid;
> + int cpu;
> int distance;
>
> /*

Yeah, not going to happen. You grow that structure from 64 bytes to 96
bytes and with that grow the static footprint of the kernel by 512k (in
the very best case) possibly again breaking things like sparc (which
have a strict limit on the kernel image size).

And all that for data that I've never needed and never even considered
useful when looking at lockdep output.

\
 
 \ /
  Last update: 2018-07-09 10:32    [W:0.049 / U:18.116 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site