lkml.org 
[lkml]   [2018]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] random: Remove unnecessary cast
On Tue, 10 Jul 2018 10:25:17 +1000
"Tobin C. Harding" <me@tobin.cc> wrote:

> Currently we are casting an argument to the macro min_t(). This is
> unnecessary since the macro already includes a cast.
>
> Remove unnecessary cast from argument to macro min_t()
>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> ---
> drivers/char/random.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index d686aa2a129b..03bd13876901 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -1736,7 +1736,7 @@ int __must_check get_random_bytes_arch(void *buf, int nbytes)
> trace_get_random_bytes_arch(left, _RET_IP_);
> while (left) {
> unsigned long v;
> - int chunk = min_t(int, left, (int)sizeof(unsigned long));
> + int chunk = min_t(int, left, sizeof(unsigned long));
>
> if (!arch_get_random_long(&v))
> break;

\
 
 \ /
  Last update: 2018-07-10 04:06    [W:0.075 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site