Messages in this thread | | | Subject | Re: [PATCH v2 2/2] drivers: core: Remove glue dirs from sysfs earlier | From | Benjamin Herrenschmidt <> | Date | Tue, 10 Jul 2018 11:37:13 +1000 |
| |
On Mon, 2018-07-09 at 17:33 -0700, Linus Torvalds wrote: > On Mon, Jul 9, 2018 at 5:29 PM Benjamin Herrenschmidt > <benh@kernel.crashing.org> wrote: > > > > For devices with a class, we create a "glue" directory between > > the parent device and the new device with the class name. > > > > This directory is never "explicitely" removed when empty however, > > explicitly > > Is the mis-spelling why you had the quotes? I do find that spelling in > the kernel, but not in drivers/base/.
No idea :-) Just my poor english, I'm not sure why I put quotes, I think I meant *explictly* as enphasis, not sure.
> > This fixes it by instead doing an explicit kobject_del() when > > the glue dir is empty, by keeping track of the number of > > child devices of the gluedir. > > Ack. This looks good to me. > > I didn't see your 1/2 - you should probably re-send that one too so > that Greg doesn't have to fish for it. But I'll Ack that one too in > this same email regardless.
OK, I didn't re-send it. Greg just nak'ed it though :-)
Cheers, Ben.
| |