lkml.org 
[lkml]   [2018]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging:fwserial Move LINUX_VENDOR_ID to firewire.h
On Mon, Jul 09, 2018 at 11:52:30AM -0400, Janani Sankara Babu wrote:
> This driver uses the same unregistered vendor id that the
> firewire core does (0xd00d1e). Hence it is exposed as a
> define in firewire.h.
>
> Signed-off-by:Janani Sankara Babu <jananis37@gmail.com>
> ---
> drivers/staging/fwserial/fwserial.c | 1 -
> include/linux/firewire.h | 2 ++
> 2 files changed, 2 insertions(+), 1 deletion(-)


staging drivers are supposed to be self-contained. Please work to get
the fwserial driver out of the staging directory before adding stuff
like this to a .h file that everyone includes.

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-07-09 09:02    [W:0.021 / U:14.252 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site