lkml.org 
[lkml]   [2018]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/2] clk: qcom: gcc: Register QUPv3 RCGs for DFS on SDM845
Date
Quoting Taniya Das (2018-06-28 04:47:31)
> @@ -3437,7 +3457,12 @@ static int gcc_sdm845_probe(struct platform_device *pdev)
> regmap_update_bits(regmap, 0x48190, BIT(0), 0x1);
> regmap_update_bits(regmap, 0x52004, BIT(22), 0x1);
>
> - return qcom_cc_really_probe(pdev, &gcc_sdm845_desc, regmap);
> + ret = qcom_cc_really_probe(pdev, &gcc_sdm845_desc, regmap);
> + if (ret)
> + return ret;
> +
> + return qcom_cc_register_rcg_dfs(pdev, gcc_dfs_clocks,
> + ARRAY_SIZE(gcc_dfs_clocks));

This looks backwards. We shouldn't expose the clks to drivers and then
make their functionality work by registering dfs clks. The order should
be swapped.

\
 
 \ /
  Last update: 2018-07-09 08:35    [W:0.022 / U:1.392 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site