Messages in this thread | | | From | Andy Shevchenko <> | Date | Sat, 7 Jul 2018 19:19:04 +0300 | Subject | Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through |
| |
On Sat, Jul 7, 2018 at 2:24 AM, Darren Hart <dvhart@infradead.org> wrote:
> return AE_CTRL_TERMINATE; > > Is unreachable as there are no "break" statements in the switch, and the default > falls through to return AE_OK. Something doesn't seem right here.
Darren, I didn't look at the code in question, though just to clarify such error codes. If the function used in acpi_walk_namespace() or alike, AE_OK means "To continue", while AE_CTRL_TERMINATE to "stop, whatever we looked for is found right now".
-- With Best Regards, Andy Shevchenko
| |