Messages in this thread | | | Subject | Re: [PATCH] wireless: mark expected switch fall-throughs | From | Johannes Berg <> | Date | Fri, 06 Jul 2018 14:29:24 +0200 |
| |
Hi Gustavo,
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through.
You dropped the remark saying you didn't review them, but did you?
> case NL80211_CHAN_WIDTH_20: > if (!ht_cap->ht_supported) > return false; > + /* else: fall through */
What's the point in else:?
We also don't necessarily write
if (!...) return false; else do_something();
but rather
if (!...) return false; do_something().
I think I'd prefer without the "else:"
johannes
| |