lkml.org 
[lkml]   [2018]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] checkpatch: forbid filesystem accesses from within the kernel
    From
    Date
    On Thu, 2018-07-05 at 14:47 -0700, Prakruthi Deepak Heragu wrote:
    > As use of sys_open/close/read/write system calls from within the kernel
    > code is inappropriate, an error is triggered if used.
    []
    > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    []
    > @@ -5372,6 +5372,13 @@ sub process {
    > "Avoid line continuations in quoted strings\n" . $herecurr);
    > }
    >
    > +# sys_open/read/write/close are not allowed in the kernel
    > + if ($line =~ /\b(sys_(?:open|read|write|close))\b/) {
    > + ERROR("FILE_OPS",
    > + "$1 is inappropriate in kernel code.\n" .
    > + $herecurr);
    > + }
    > +

    Is this really useful?

    As far as I can tell, this would only give
    false positives on all existing kernel code.

    \
     
     \ /
      Last update: 2018-07-05 23:58    [W:2.657 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site