lkml.org 
[lkml]   [2018]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.4] nvme-pci: initialize queue memory before interrupts
On Tue, Jun 19, 2018 at 06:23:06PM +0100, Ben Hutchings wrote:
> From: Keith Busch <keith.busch@intel.com>
>
> commit 161b8be2bd6abad250d4b3f674bdd5480f15beeb upstream.
>
> A spurious interrupt before the nvme driver has initialized the completion
> queue may inadvertently cause the driver to believe it has a completion
> to process. This may result in a NULL dereference since the nvmeq's tags
> are not set at this point.
>
> The patch initializes the host's CQ memory so that a spurious interrupt
> isn't mistaken for a real completion.
>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> [bwh: Backported to 4.4: adjust context]
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> ---
> drivers/nvme/host/pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Now applied, thanks.

greg k-h

\
 
 \ /
  Last update: 2018-07-05 18:58    [W:0.493 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site