Messages in this thread | | | From | Nikolaus Voss <> | Date | Wed, 4 Jul 2018 15:27:06 +0200 | Subject | [PATCH v3 0/2] IIO: st_sensors_i2c: improve device enumeration |
| |
When trying to instantiate a st_accel_i2c device from an ACPI based system, I ran into some problems:
For my device, there is no ACPI match table entry, so rather than creating /allocating a new ACPI HID for the device, I wanted to use an existing DT table compatible entry via creating an ACPI_DT_NAMESPACE_HID /PRP0001 HID ACPI entry (see Documentation/acpi/enumeration.txt).
This did not work because st_accel_i2c.c bails out if there is a ACPI node but no ACPI table match. Use device_get_match_data API to get the right driver data.
acpi_device_get_match_data() currently doesn't return DT compatible matches. A separate patch is submitted to fix this.
v3: - remove unused i2c_device_id .driver_data fields as suggested by Javier Martinez Canillas. v2: - use device_get_match_data API as suggested by Andy Shevchenko - removed syncing DT/I2C table names as Jonathan Cameron pointed out this would be an ABI change - converting from probe() to probe_new() is moved into a separate patch (as suggested by Jonathan Cameron)
Nikolaus Voss (2): IIO: st_accel_i2c.c: Simplify access to driver data IIO: st_accel_i2c.c: Use probe_new() instead of probe()
drivers/iio/accel/st_accel_i2c.c | 61 ++++++++++++++------------------ 1 file changed, 26 insertions(+), 35 deletions(-)
-- 2.17.1
| |