Messages in this thread | | | Date | Wed, 4 Jul 2018 08:36:39 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v3] mfd: arizona: Don't use regmap_read_poll_timeout |
| |
On Thu, 28 Jun 2018, Charles Keepax wrote:
> Some Arizona CODECs have a small timing window where they will > NAK an I2C transaction if it happens before the boot done bit is > set. This can cause the read of the register containing the boot > done bit to fail until it is set. Since regmap_read_poll_timeout > will abort polling if a read fails it can't be reliably used to > poll the boot done bit over I2C. > > Do a partial revert of ef84f885e037 ("mfd: arizona: Refactor > arizona_poll_reg"), removing the regmap_read_poll_timeout but > leaving the refactoring to make the arizona_poll_reg take more > sensible arguments. > > Fixes: ef84f885e037 ("mfd: arizona: Refactor arizona_poll_reg") > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> > --- > > Changes since v2: > - Refactor to remove initialisation of ret variable > > Thanks, > Charles > > drivers/mfd/arizona-core.c | 34 ++++++++++++++++++++++++++-------- > 1 file changed, 26 insertions(+), 8 deletions(-)
Applied, thanks.
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |