lkml.org 
[lkml]   [2018]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5 V5] Add a function(ioremap_encrypted) for kdump when AMD sme enabled
    On Tue, Jul 03, 2018 at 06:58:14PM +0800, lijiang wrote:
    > For kdump, the elf header finally use the crash kernel reserved memory, it is not an old memory.

    Lamme repeat my suggestion:

    So beef up the logic in __ioremap_caller() to figure out based on the
    address whether to access the memory encrypted or not. In general, you
    can deduce, based on the region you're mapping, whether you need to map
    in encrypted or decrypted.

    For example:

    addr = elfcorehdr_addr;

    /* Read Elf header */
    rc = elfcorehdr_read((char *)&ehdr, sizeof(Elf64_Ehdr), &addr);
    if (rc < 0)
    return rc;

    elfcorehdr_addr has that elfcorehdr address. So you can check which address
    you're mapping and do:

    __ioremap_caller:

    ...
    prot = __ioremap_compute_prot(...);

    and that __ioremap_compute_prot() function which you will add will have
    all that logic to determine encrypted or not by comparing addresses etc.

    Does that make more sense?

    --
    Regards/Gruss,
    Boris.

    Good mailing practices for 400: avoid top-posting and trim the reply.

    \
     
     \ /
      Last update: 2018-07-03 13:15    [W:4.452 / U:0.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site