Messages in this thread Patch in this message | | | From | Faiz Abbas <> | Subject | [PATCH v2] can: m_can: Fix runtime resume call | Date | Tue, 3 Jul 2018 16:41:02 +0530 |
| |
pm_runtime_get_sync() returns a 1 if the state of the device is already 'active'. This is not a failure case and should return a success.
Therefore fix error handling for pm_runtime_get_sync() call such that it returns success when the value is 1.
Also cleanup the TODO for using runtime PM for sleep mode as that is implemented.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> ---
Changes in v2:
rebased to latest mainline
drivers/net/can/m_can/m_can.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index b397a33f3d32..ac4c6dc2f8c8 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -634,10 +634,12 @@ static int m_can_clk_start(struct m_can_priv *priv) int err; err = pm_runtime_get_sync(priv->device); - if (err) + if (err < 0) { pm_runtime_put_noidle(priv->device); + return err; + } - return err; + return 0; } static void m_can_clk_stop(struct m_can_priv *priv) @@ -1687,8 +1689,6 @@ static int m_can_plat_probe(struct platform_device *pdev) return ret; } -/* TODO: runtime PM with power down or sleep mode */ - static __maybe_unused int m_can_suspend(struct device *dev) { struct net_device *ndev = dev_get_drvdata(dev); -- 2.17.0
| |