Messages in this thread | | | From | Luis Araneda <> | Date | Tue, 3 Jul 2018 03:18:49 -0400 | Subject | Re: [RFC PATCH 5/5] arm: dts: zynq: remove "zynq" prefix from compatible property |
| |
Hi Michal,
On Thu, Jun 28, 2018 at 2:42 AM Michal Simek <michal.simek@xilinx.com> wrote: > zynq name here is correct which is saying that hardblock is going to be > described. Without it it is suggesting that hardblock is not used and it > is for example on zybo with microblaze.
In my opinion, the zynq name is just adding redundant information to the "xlnx,zynq-7000" value. Taking the Zybo board, the current compatible property is: > compatible = "digilent,zynq-zybo", "xlnx,zynq-7000";
I'm proposing to change it to: > compatible = "digilent,zybo", "xlnx,zynq-7000"; (I know I must keep the old value too, I'm simplifying)
In the case of a Zybo board with a microblaze, the property could be: > compatible = "digilent,zybo", "xlnx,microblaze";
That would allow to differentiate between zynq and microblaze.
I have no problem on dropping the patch if you like. There might be something that I'm not seeing or a use case that I'm missing.
Thanks,
Luis Araneda.
| |