lkml.org 
[lkml]   [2018]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/14] thermal: ti-soc-thermal: fix TALERT IRQ handling for DRA752
    From
    Date


    On Wednesday 25 July 2018 07:57 PM, Bartlomiej Zolnierkiewicz wrote:
    > On Wednesday, July 11, 2018 07:49:41 AM J, KEERTHY wrote:
    >>
    >> On 5/14/2018 5:12 PM, Bartlomiej Zolnierkiewicz wrote:
    >>> .report_temperature is not set in dra752_data which
    >>> results in temperature updates not being propagated by
    >>> ti_bandgap_talert_irq_handler() (it doesn't make much
    >>> sense to handle TALERT IRQ without reporting temperature
    >>> updates to the thermal core). Fix it.
    >>
    >> ATM no one is using TALERT as the thermal software polls on the
    >> temperature. No real benefit from TALERT.
    >>
    >> TALERT is set at different temperature and software polling thresholds
    >> come from Device tree and i believe its best for software to go by
    >> polling and then act on trip points.
    >
    > Could you please explain what do you mean by "no one is using
    > TALERT"?
    >
    > The code in ti_bandgap_probe() sets TALERT thresholds and requests
    > IRQ if the TI_BANDGAP_FEATURE_TALERT feature flag is set (and this
    > flag is set in omap4460_data, omap4470_data, omap5430_data and
    > dra752_data).

    The software thresholds and the polling takes care of reducing the
    temperature. What i actually meant was we never relied on talert and the
    polling takes care of keeping a check on the temperature.

    Regards,
    Keerthy

    >
    > Best regards,
    > --
    > Bartlomiej Zolnierkiewicz
    > Samsung R&D Institute Poland
    > Samsung Electronics
    >

    \
     
     \ /
      Last update: 2018-07-27 06:45    [W:2.380 / U:0.488 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site