Messages in this thread | | | Date | Tue, 24 Jul 2018 09:42:09 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v5] x86: Avoid pr_cont() in show_opcodes(). |
| |
* Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote:
> On 2018/07/18 20:57, Ingo Molnar wrote: > > > > * Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote: > > > >> Since syzbot is confused by concurrent printk() messages [1], > >> this patch changes show_opcodes() to use %ph format string. > >> > >> When we start adding prefix to each line of printk() output, > >> we will be able to handle concurrent printk() messages. > >> > >> [1] https://syzkaller.appspot.com/text?tag=CrashReport&x=139d342c400000 > >> > >> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > >> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > > > > Wasn't that variant of the patch written by Rasmus? > > Rasmus Villemoes taught me that we can use "%*ph" format string and pass > length as arguments for "*" part. Then, since Joe Perches suggested me to > use #define for length variable, I updated to use "#define length immediate" > and replaced "%*ph" with "%" __strigify(length) "ph" and removed length from > arguments. That is v5 patch. > > > > > If so then the changelog should start with: > > > > From: Rasmus Villemoes <linux@rasmusvillemoes.dk> > > OK. I posted v6 patch with From: line updated.
Please do that only if it was mainly written by him - otherwise just tell me that it's yours and I'll apply it as such.
Thanks,
Ingo
| |