Messages in this thread | | | From | Logan Gunthorpe <> | Date | Fri, 20 Jul 2018 10:33:36 -0600 | Subject | Re: [PATCH 8/8] NTB: ntb_test: Fix bug when counting remote files |
| |
On 15/06/18 01:51 PM, Serge Semin wrote: > I also tested this script in the looped-back setup. It is the case when two > NTB-device ports are available at the same RootComplex. So the NTB can be > configured from the single executional context. In this case the REMOTE_HOST is left > empty, so the colon is left prepended to the corresponding paths and causes multiple > errors including the one fixed by this patch. In order to fix it, we need to discard > the colon for remote-less case, for instance, by the next patch: > > @@ -482,7 +495,11 @@ function perf_test() > function ntb_tool_tests() > { > LOCAL_TOOL="$DEBUGFS/ntb_tool/$LOCAL_DEV" > - REMOTE_TOOL="$REMOTE_HOST:$DEBUGFS/ntb_tool/$REMOTE_DEV" > + if [[ "${REMOTE_HOST}" != "" ]]; then > + REMOTE_TOOL="$REMOTE_HOST:$DEBUGFS/ntb_tool/$REMOTE_DEV" > + else > + REMOTE_TOOL="$DEBUGFS/ntb_tool/$REMOTE_DEV" > + fi > > echo "Starting ntb_tool tests..." > > And so on for REMOTE_PP and REMOTE_PERF. It is necessary for NTB devices, which ports > are looped-back to the same Root-Port. Would you be amenable if you resent this patch > together with the fix I suggested? I took a closer look at this and it's not necessary. (Note: I do the majority of my testing in a looped-back setup).
What you didn't notice is that split_remote() separates the colon whether there is a host or not. It's not passed to ssh or cat (or whatever) directly. So the change you propose will actually break the how it was designed.
Logan
| |