Messages in this thread | | | From | Wanpeng Li <> | Date | Fri, 20 Jul 2018 11:53:05 +0800 | Subject | Re: [PATCH v3 5/6] KVM: X86: Add NMI support to PV IPIs |
| |
On Fri, 20 Jul 2018 at 00:31, Radim Krčmář <rkrcmar@redhat.com> wrote: > > 2018-07-03 14:21+0800, Wanpeng Li: > > From: Wanpeng Li <wanpengli@tencent.com> > > > > The NMI delivery mode of ICR is used to deliver an NMI to the processor, > > and the vector information is ignored. > > > > Cc: Paolo Bonzini <pbonzini@redhat.com> > > Cc: Radim Krčmář <rkrcmar@redhat.com> > > Cc: Vitaly Kuznetsov <vkuznets@redhat.com> > > Signed-off-by: Wanpeng Li <wanpengli@tencent.com> > > --- > > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > > @@ -479,7 +479,16 @@ static int __send_ipi_mask(const struct cpumask *mask, int vector) > > } > > } > > > > - ret = kvm_hypercall3(KVM_HC_SEND_IPI, ipi_bitmap_low, ipi_bitmap_high, vector); > > + switch (vector) { > > + default: > > + icr = APIC_DM_FIXED | vector; > > + break; > > + case NMI_VECTOR: > > + icr = APIC_DM_NMI; > > I think it would be better to say that KVM interprets NMI_VECTOR and > sends the interrupt as APIC_DM_NMI.
Yeah, in addition, SDM 10.6.1 also mentioned that: Delivery mode: 100 (NMI) Delivers an NMI interrupt to the target processor or processors. The vector information is ignored.
Regards, Wanpeng Li
| |