Messages in this thread | | | Subject | Re: [PATCH v3 5/6] KVM: X86: Add NMI support to PV IPIs | From | Paolo Bonzini <> | Date | Fri, 20 Jul 2018 10:04:23 +0200 |
| |
On 20/07/2018 05:53, Wanpeng Li wrote: >>> - ret = kvm_hypercall3(KVM_HC_SEND_IPI, ipi_bitmap_low, ipi_bitmap_high, vector); >>> + switch (vector) { >>> + default: >>> + icr = APIC_DM_FIXED | vector; >>> + break; >>> + case NMI_VECTOR: >>> + icr = APIC_DM_NMI; >> I think it would be better to say that KVM interprets NMI_VECTOR and >> sends the interrupt as APIC_DM_NMI.
It's not KVM, this is arch/x86/kernel/kvm.c so the guest side.
Paolo
> Yeah, in addition, SDM 10.6.1 also mentioned that: > Delivery mode: > 100 (NMI) Delivers an NMI interrupt to the target processor or > processors. The vector information is ignored.
| |