Messages in this thread | | | From | Pavel Tatashin <> | Date | Mon, 2 Jul 2018 14:47:20 -0400 | Subject | Re: [PATCH] mm/sparse: Make sparse_init_one_section void and remove check |
| |
On Mon, Jul 2, 2018 at 11:43 AM <osalvador@techadventures.net> wrote: > > From: Oscar Salvador <osalvador@suse.de> > > sparse_init_one_section() is being called from two sites: > sparse_init() and sparse_add_one_section(). > The former calls it from a for_each_present_section_nr() loop, > and the latter marks the section as present before calling it. > This means that when sparse_init_one_section() gets called, we already know > that the section is present. > So there is no point to double check that in the function. > > This removes the check and makes the function void. > > Signed-off-by: Oscar Salvador <osalvador@suse.de>
Thank you Oscar.
Reviewed-by: Pavel Tatashin <pasha.tatashin@oracle.com>
> --- > mm/sparse.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-)
| |