lkml.org 
[lkml]   [2018]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] USB: serial: cp210x: Implement GPIO support for CP2102N
    Date
    Johan Hovold <johan@kernel.org> writes:

    >> Not quite. It is not from a forum post, but from a SiLabs Knowledge
    >> Base article
    >> (https://www.silabs.com/community/interface/knowledge-base.entry.html/2017/06/12/fletcher_checksumfo-TeDF)
    >
    > Yeah, that's the one I was referring to.
    >
    >> That article states explicitly that the code was taken from Wikipedia,
    >> so it is CC-SA, which is to the best of my knowledge 1) compatible
    >> with GPL, and 2) does not require attribution if the original material
    >> is missing it, and it does. So AFAICT we are clear on the licensing
    >> front.
    >
    > First of all I can't seem to find that code snippet on the wiki page it
    > does refer to, so I'm still not convinced.

    It was there in older versions of the article. See for example:
    https://en.wikipedia.org/w/index.php?title=Fletcher%27s_checksum&oldid=730327006

    > Second, this should have been high-lighted in your submission somehow.

    Definitely. All code has an original author who deserves credit. And if
    you cannot find the original author, then there is always a risk than
    someone along the line stole the code... Maybe long before it ended up
    in Wikipedia. But that doesn't matter.

    Doesn't seem worth the risk for a simple checksum algorithm which
    probably has lots of GPL implementations.


    Bjørn

    \
     
     \ /
      Last update: 2018-07-02 20:05    [W:6.413 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site