lkml.org 
[lkml]   [2018]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernfs: Replace strncpy with memcpy
On Sun, Jul 01, 2018 at 01:57:13PM -0700, Guenter Roeck wrote:
> gcc 8.1.0 complains:
>
> fs/kernfs/symlink.c:91:3: warning:
> 'strncpy' output truncated before terminating nul copying
> as many bytes from a string as its length
> fs/kernfs/symlink.c: In function 'kernfs_iop_get_link':
> fs/kernfs/symlink.c:88:14: note: length computed here
>
> Using strncpy() is indeed less than perfect since the length of data to
> be copied has already been determined with strlen(). Replace strncpy()
> with memcpy() to address the warning and optimize the code a little.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun

\
 
 \ /
  Last update: 2018-07-02 16:53    [W:0.047 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site