Messages in this thread | | | Date | Mon, 02 Jul 2018 22:43:05 +0900 (KST) | Subject | Re: [PATCH] TTY: isdn: Replace strncpy with memcpy | From | David Miller <> |
| |
From: Guenter Roeck <linux@roeck-us.net> Date: Sun, 1 Jul 2018 13:57:38 -0700
> gcc 8.1.0 complains: > > drivers/isdn/i4l/isdn_tty.c: In function 'isdn_tty_suspend.isra.1': > drivers/isdn/i4l/isdn_tty.c:790:3: warning: > 'strncpy' output truncated before terminating nul copying > as many bytes from a string as its length > drivers/isdn/i4l/isdn_tty.c:778:6: note: length computed here > > drivers/isdn/i4l/isdn_tty.c: In function 'isdn_tty_resume': > drivers/isdn/i4l/isdn_tty.c:880:3: warning: > 'strncpy' output truncated before terminating nul copying > as many bytes from a string as its length > drivers/isdn/i4l/isdn_tty.c:817:6: note: length computed here > > Using strncpy() is indeed less than perfect since the length of data to > be copied has already been determined with strlen(). Replace strncpy() > with memcpy() to address the warning and optimize the code a little. > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Applied.
| |