lkml.org 
[lkml]   [2018]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] watchdog: change ITCO_WDT type from tristate to bool
From
Date
On 07/02/2018 01:18 AM, Tian, Baofeng wrote:
> From: "Tian, Baofeng" <baofeng.tian@intel.com <mailto:baofeng.tian@intel.com>>
> Subject: [PATCH] watchdog: change ITCO_WDT type from tristate to bool
>
> tristate will allow kernel config it to M and build ko file,
> this will cause build allmodconfig errors as necessary
> symbols have not been exported.
> change it to bool, only allow config ITCO_WDT to yes/no.
>
> Signed-off-by: Tian, Baofeng <baofeng.tian@intel.com <mailto:baofeng.tian@intel.com>>

This works today. I don't see a point changing it, and I am wary doing so.
There are systems where the iTCO watchdog doesn't work (I own one of those),
even though it instantiates, and I am wary of force-loading it.

Besides, you don't explain which "necessary symbols have not been exported".
I do not plan to spend time trying to find out what those symbols are, and
why this would suddenly be a problem.

Guenter

> ---
>  drivers/watchdog/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9af07fd..f991e93 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1049,7 +1049,7 @@ config INTEL_MID_WATCHDOG
>         To compile this driver as a module, choose M here.
>
>  config ITCO_WDT
> -     tristate "Intel TCO Timer/Watchdog"
> +     bool "Intel TCO Timer/Watchdog"
>       depends on (X86 || IA64) && PCI
>       select WATCHDOG_CORE
>       depends on I2C || I2C=n
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2018-07-02 15:19    [W:0.085 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site