Messages in this thread | | | Subject | Re: [PATCH] watchdog: change ITCO_WDT type from tristate to bool | From | Guenter Roeck <> | Date | Mon, 2 Jul 2018 06:16:49 -0700 |
| |
On 07/02/2018 01:18 AM, Tian, Baofeng wrote: > From: "Tian, Baofeng" <baofeng.tian@intel.com <mailto:baofeng.tian@intel.com>> > Subject: [PATCH] watchdog: change ITCO_WDT type from tristate to bool > > tristate will allow kernel config it to M and build ko file, > this will cause build allmodconfig errors as necessary > symbols have not been exported. > change it to bool, only allow config ITCO_WDT to yes/no. > > Signed-off-by: Tian, Baofeng <baofeng.tian@intel.com <mailto:baofeng.tian@intel.com>>
This works today. I don't see a point changing it, and I am wary doing so. There are systems where the iTCO watchdog doesn't work (I own one of those), even though it instantiates, and I am wary of force-loading it.
Besides, you don't explain which "necessary symbols have not been exported". I do not plan to spend time trying to find out what those symbols are, and why this would suddenly be a problem.
Guenter
> --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 9af07fd..f991e93 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -1049,7 +1049,7 @@ config INTEL_MID_WATCHDOG > To compile this driver as a module, choose M here. > > config ITCO_WDT > - tristate "Intel TCO Timer/Watchdog" > + bool "Intel TCO Timer/Watchdog" > depends on (X86 || IA64) && PCI > select WATCHDOG_CORE > depends on I2C || I2C=n > -- > 2.7.4 >
| |