lkml.org 
[lkml]   [2018]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] usb: musb: Call musb_platform_exit from musb_stop
On Thu, Jul 19, 2018 at 9:07 PM, Bin Liu <b-liu@ti.com> wrote:
> Hi,
>
> On Thu, Jul 19, 2018 at 03:40:38PM +0530, Jagan Teki wrote:
>> musb stop is musb core call during unregister or shutting down
>> gadget or host musb. For graceful exit add musb_platform_exit
>> on musb_stop so-that it can exit the musb platform driver as well.
>
> Thanks for the patch. but musb_stop() is called in the .udc_stop() and
> host .stop() hooks, which can stop (and restart) at any time by the udc
> or host core, not really during unregister. musb_platform_init() is not
> called in .udc_start() and .start() hooks, so we shouldn't add
> musb_platform_exit() in musb_stop().

Thanks for the explanation.

Look like musb_platform_exit calling during musb_remove call of
platform driver. can you explain how the shutdown sequence happen
because of if udc_stop call musb_stop to shutdown how come
platform_exit will shutdown it's PHY and CLK bits. or is it in
reverse?

Jagan.

\
 
 \ /
  Last update: 2018-07-19 19:46    [W:0.062 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site