lkml.org 
[lkml]   [2018]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pty: fix O_CLOEXEC for TIOCGPTPEER
On 2018-07-19, Matthijs van Duin <matthijsvanduin@gmail.com> wrote:
> It was being ignored because the flags were not passed to fd allocation.
>
> Fixes: 54ebbfb16034 ("tty: add TIOCGPTPEER ioctl")

Acked-by: Aleksa Sarai <asarai@suse.de>

> Signed-off-by: Matthijs van Duin <matthijsvanduin@gmail.com>
> ---
> drivers/tty/pty.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c
> index b0e2c4847a5d..678406e0948b 100644
> --- a/drivers/tty/pty.c
> +++ b/drivers/tty/pty.c
> @@ -625,7 +625,7 @@ int ptm_open_peer(struct file *master, struct tty_struct *tty, int flags)
> if (tty->driver != ptm_driver)
> return -EIO;
>
> - fd = get_unused_fd_flags(0);
> + fd = get_unused_fd_flags(flags);
> if (fd < 0) {
> retval = fd;
> goto err;

--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-07-19 19:18    [W:0.088 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site