lkml.org 
[lkml]   [2018]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 1/8] mtd: rawnand: ams-delta: Use private structure
    On Thu, 19 Jul 2018 01:57:03 +0200
    Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote:

    > Introduce a driver private structure and allocate it on device probe.
    > Use it for storing nand_chip structure, GPIO descriptors prevoiusly
    > stored in static variables as well as io_base pointer previously passed
    > as nand controller data or platform driver data.

    That's a good thing. Thanks for doing that.

    > Subsequent patches
    > may populate the structure with more members as needed.
    >
    > While at it, fix missing mtd->dev.parent and drop useless mtd->owner.

    I'd prefer to have it done in a separate patch if you don't mind.

    \
     
     \ /
      Last update: 2018-07-19 08:19    [W:4.354 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site