lkml.org 
[lkml]   [2018]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv5 07/19] x86/mm: Mask out KeyID bits from page table entry pfn
    On Wed, Jul 18, 2018 at 04:13:20PM -0700, Dave Hansen wrote:
    > On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote:
    > > + } else {
    > > + /*
    > > + * Reset __PHYSICAL_MASK.
    > > + * Maybe needed if there's inconsistent configuation
    > > + * between CPUs.
    > > + */
    > > + physical_mask = (1ULL << __PHYSICAL_MASK_SHIFT) - 1;
    > > + }
    >
    > This seems like an appropriate place for a WARN_ON(). Either that, or
    > axe this code.

    There's pr_err_once() above in the function.

    --
    Kirill A. Shutemov

    \
     
     \ /
      Last update: 2018-07-19 11:55    [W:4.059 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site