lkml.org 
[lkml]   [2018]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node
Hi Krzysztof,

On 18 July 2018 at 19:25, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 18 July 2018 at 14:59, Anand Moon <linux.amoon@gmail.com> wrote:
>> Add missing GIC interrupts property for pwm nodes.
>>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>> Fixed the patch indentation issue with all tabs.
>> sorry checkpatch could not figure out the error.
>> ---
>> arch/arm/boot/dts/exynos5.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
>> index 5d2f0a0..f48fb9b 100644
>> --- a/arch/arm/boot/dts/exynos5.dtsi
>> +++ b/arch/arm/boot/dts/exynos5.dtsi
>> @@ -169,6 +169,11 @@
>> pwm: pwm@12dd0000 {
>> compatible = "samsung,exynos4210-pwm";
>> reg = <0x12DD0000 0x100>;
>> + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
>
> OK, thanks for v2. Now only tabs are used but in previous mail I
> mentioned which example to use - the rtc node which nicely aligns
> continued lines. Why you did not follow this alignment?
>
> I'll fix it when applying, no need to resend.
>
> Best regards,
> Krzysztof

Thanks, I follow the tab protocol otherwise checkpatch would have
complained of tab/space issue.

Best Regards
-Anand

\
 
 \ /
  Last update: 2018-07-18 19:50    [W:0.453 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site